fix(claude): import the claude-fix-settings recipe in shared recipes#520
Merged
Merged
Conversation
PR #518 added sjust/recipes/shared/09-claude-fix-settings.just and its scripts but did not add the matching import to sjust/recipes/04-shared.just. The recipe file was therefore never loaded, so 'sjust claude-fix-settings' failed with 'justfile does not contain recipe'. Add the import line, consistent with the sibling 07 and 08 claude recipes. Verified with 'just --list': claude-fix-settings and claude-fix-settings-info now appear. Assisted-by: claude-code/claude-opus-4-8[1m]
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes missing inclusion of the claude-fix-settings shared recipe so sjust claude-fix-settings is available when running via sjust/justfile (regression from #518).
Changes:
- Adds the missing
import "shared/09-claude-fix-settings.just"line to the shared recipes aggregator (sjust/recipes/04-shared.just).
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sjust claude-fix-settingsfails with:This happens on current
master(commit 90c6ee6), so updating a local checkout does not help.Root cause
PR #518 added the recipe file
sjust/recipes/shared/09-claude-fix-settings.just(which definesclaude-fix-settingsandclaude-fix-settings-info) together with its scripts, but it did not add the matchingimporttosjust/recipes/04-shared.just. That file imports the shared recipes01through08;09was missing, so the recipe file is never loaded and the recipes do not exist fromsjust's point of view.The sibling Claude recipes
07-claude-statusline.justand08-claude-usage.justwere imported correctly; only09was overlooked.Fix
Add the missing import line to
sjust/recipes/04-shared.just:Verification
just --justfile sjust/justfile --listnow lists both recipes:Regression from #518.